Open tavishjain opened 6 years ago
@tavishjain Some countries have phone number length > 10
@Bloody-Badboy that can be classified according to the countries code. Since I dont know how to use the country code widget, I added only for india that is 10 digits
@tavishjain Let's not restrict it to 10 digit, phone numbers are 7 to 13 digits are valid phone numbers.
So phone number is invalid if it length than 6 and and greater than 13. Put it in Utils. Also, user Patterns.Phone regex.
@ritesh-singh changed the conditions for the phone number. The user can now enter a mobile number varying from 7 to 13 digits.
Also created a Util class and placed the code in it
@tavishjain Also, take update from upstream first.
@ritesh-singh my branch is up to date
@ritesh-singh Did the changes
@ritesh-singh I hope no more changes to be done now
Please review this PR
?
Fill out the following while publishing a new pull request.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) User is now not able to enter mobile number of any length at the Mobile Registration Activity
What is the current behavior? (You can also link to an open issue here) User is not prompted of wrong number of digits
What is the new behavior (if this is a feature change)? User is now prompted of wrong number of digits
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: