UdacityAndroidDevScholarship / blood-donation

This application is a collaborative project made by the Google Udacity Android Developer Scholars.
81 stars 123 forks source link

Resolved Issue #76 #81

Open tavishjain opened 6 years ago

tavishjain commented 6 years ago

Fill out the following while publishing a new pull request.

Bloody-Badboy commented 6 years ago

@tavishjain Some countries have phone number length > 10

tavishjain commented 6 years ago

@Bloody-Badboy that can be classified according to the countries code. Since I dont know how to use the country code widget, I added only for india that is 10 digits

ritesh-singh commented 6 years ago

@tavishjain Let's not restrict it to 10 digit, phone numbers are 7 to 13 digits are valid phone numbers.

So phone number is invalid if it length than 6 and and greater than 13. Put it in Utils. Also, user Patterns.Phone regex.

tavishjain commented 6 years ago

@ritesh-singh changed the conditions for the phone number. The user can now enter a mobile number varying from 7 to 13 digits.

Also created a Util class and placed the code in it

ritesh-singh commented 6 years ago

@tavishjain Also, take update from upstream first.

tavishjain commented 6 years ago

@ritesh-singh my branch is up to date

@ritesh-singh Did the changes

tavishjain commented 6 years ago

@ritesh-singh I hope no more changes to be done now

tavishjain commented 6 years ago

Please review this PR

tavishjain commented 6 years ago

?