Closed groverankush closed 6 years ago
Take update from upstream develop, you will get the latest code, which was pushed yesterday. Merge with your local develop or any branch, if any merge conflict, resolve them.
In the end do a basic round rounds of unit testing, as in if login is working, user details are getting saved and others.
Why is it closed ankush, it's not merged yet.
Soon I'll be creating another pull request
Fill out the following while publishing a new pull request.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Added Location Util to manage location access. This can be used for both signup and bloodRequest. Manage location end to end.
Added validation checks in UserDetailActivity
Some minor UI fixes.
What is the current behaviour? (You can also link to an open issue here)
There were many missing cases for fetching location.
Does not have validation checks in user detail activity.
What is the new behaviour (if this is a feature change)?
LocationUtil is added to manage location.
Now UserDetailActivity does not take invalid inputs.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: