No Close or Cancel button on Dialog

UdacityAndroidDevScholarship / blood-donation

This application is a collaborative project made by the Google Udacity Android Developer Scholars.

81 stars 123 forks source link

No Close or Cancel button on Dialog #94

Closed omi90 closed 6 years ago

omi90 commented 6 years ago

Feature Request

Description

If you click on + Button on main screen, a dialog comes for user to request blood or donate blood with some other details to fill up. But on the same dialog there is no provision to close it either with a close icon or a button, also back button also does not work to close the dialog. There is only one button Submit in the bottom.

How would the above feature be useful?

This would help user to close the dialog if he/she does not have anything to Submit and just checking the features of the app.

KamalMrock commented 6 years ago

@omi90 send screen shot.

omi90 commented 6 years ago

Cancel Button added adjacent to Submit button. screenshot_20180506-234959

animeshroydev commented 6 years ago

I would like to work on it...

KamalMrock commented 6 years ago

it is done @animeshroydev

animeshroydev commented 6 years ago

Is it merged? @KamalMrock

KamalMrock commented 6 years ago

Not yet. You can work here #88 @animeshroydev

animeshroydev commented 6 years ago

But I have implemented this issue and improved the button to round corners. I am going to make a pull request just review it. If you don't like just close it. I think it will consider as a contribution...

KamalMrock commented 6 years ago

Yes,Send your PR @animeshroydev and don't forget to add screen shot.

groverankush commented 6 years ago

Not required right now