search

UdacityAndroidDevScholarship / gis-2k18

This application is a collaborative project made by the Google Udacity Android Developer Scholars.
49 stars 85 forks source link

Feature login screen UI #26

Closed derrickabreo closed 6 years ago

derrickabreo commented 6 years ago

Description

Modified login Screen UI (Only the xml and affected files)

ScreenShots

Changes/Updates

  1. Modified content_login.xml file
  2. Added commonly used dimensions in dimens.xml
  3. Added Roboto font
  4. Added String values in string.xml
  5. Added extra color in color.xml
amarjeetkapoor1 commented 6 years ago

Remove .idea files and commit again and for mods and co-mods merge with squash and merge option only.

derrickabreo commented 6 years ago

@amarjeetkapoor1 I Have removed .idea files before pushing the changes to github.

amarjeetkapoor1 commented 6 years ago

Sorry, For that. I have requested the respective mod for review.

P.S. Can you add sign in functioning with firebase as we already have a sign-in page but its not functioning, plus no sign-up page

derrickabreo commented 6 years ago

@amarjeetkapoor1 Sure! always ready to code! But more information would be helpful.

derrickabreo commented 6 years ago

@knightcube SignUp screen with just email and password registration right?

knightcube commented 6 years ago

yup @derrickabreo

derrickabreo commented 6 years ago

@knightcube @amarjeetkapoor1 Should I use this same PR for sign Up page? or Should I create a new PR?

amarjeetkapoor1 commented 6 years ago

Your choice but I think creating new PR will be better. So, that we can merge this one if mods approve.

amarjeetkapoor1 commented 6 years ago

@Rahulxx01 @knightcube Should we merge it to be specific squash and merge?

knightcube commented 6 years ago

Yes we can go ahead and merge it