search

UdacityAndroidDevScholarship / gis-2k18

This application is a collaborative project made by the Google Udacity Android Developer Scholars.
49 stars 85 forks source link

Adding editing option in user details #85

Closed sud8443 closed 6 years ago

sud8443 commented 6 years ago

Added picture adding feature from camera and gallery. Added empty fragment classes to be implemented once backend for this is set and merger with master so that it can be automatically merged. This is in reference to the issue #56

TheRaider commented 6 years ago

@sud8443 I have noticed the following things regarding your pull request.

  1. Don't open profile activity when you click on User Details as it is also being editable in members section also (NavBar - members - phase1/phase2 - ProfileActivity). But it should not be editable. (Don't make any changes to profile activity as it is uneditable by default. )
  2. Directly open Edit Profile Activity with editable = false when you click on User Details.
  3. And you have not added any editing options for projects and stories. Are you still working on it?
  4. When you click on edit profile photo button, it's selector is showing that you have clicked the complete view. But it's not the case right, we want only the edit button to be shown as clicked right!!

I think the above all are to be done before merging the pull request.

sud8443 commented 6 years ago

@TheRaider I will work on all this and update my PR till the evening.

TheRaider commented 6 years ago

@sud8443 OK. Submit it as soon as possible so that we can review it and merge.

sud8443 commented 6 years ago

@TheRaider already started working on it.

sud8443 commented 6 years ago

@TheRaider I have some issues I need to discuss: 1) I have made the whole image view clickable so that the user gets more space to be able to change the image as make a small button clickable may not be right and make the user click the button multiple time to change the image. I got this idea from LinkedIn's feature. 2) Is profile activity not editable? and I directly have to open the EditProfileActivity when user details is clicked right ? 3) I have to make seperate Fragments and Recycler view to make editable versions of GIS stories and Projects right ?

TheRaider commented 6 years ago

@sud8443

  1. But it's better to have it limited to the profile pic to avoid misconception for the user
  2. Yes 3.Yes
sud8443 commented 6 years ago

@TheRaider 1) Yes I agree with you but I have not made those changes since Abani will be changing it completely 2) I thought it's not good idea to directly open the edit screen because sometimes the user just wants to view his details and not edit them, so I am passing in an extra variable in the Intent to track whether ProfileActivity is been opened because of Navigation Menu or the Members->Phase1->See more 3) Done

TheRaider commented 6 years ago

@Rahulxx01 @knightcube I have reviewed these. Everything looks fine. Please review this once so that we can merge it

TheRaider commented 6 years ago

Great Work !! Thank you @sud8443