search

UdacityAndroidDevScholarship / gis-2k18

This application is a collaborative project made by the Google Udacity Android Developer Scholars.
49 stars 85 forks source link

Added users details activity feature #86

Closed abanidas closed 6 years ago

abanidas commented 6 years ago

Fixes issue #56 Implemented the User Details Activity for logged in user, with user's profile, stories and project sections. For now it is working on demo data only. When actual data comes then it can be implemented accordingly for performing specific function.

BEFORE AND AFTER SCREENSHOT

BEFORE NA

AFTER

About Section

GIS Section

Project Section

TheRaider commented 6 years ago

@abanidas The following are the issues I have noticed regarding your pull request.

  1. Change the color of the edit icon to white as the black color edit icon a bit weird and is not syncing with the backgrond colours. Change all the icon colours to match the background.
  2. Change the color of the tablayout background to that of the collapsing toolbar so that it looks uniform.
  3. When scrolled up , a part of toolbar remains to the top of the tablayout which looks weird. Either display the Toobar with Title or make it invisible on scroll up!

Do solve these things to review it and merge it.

abanidas commented 6 years ago

@TheRaider you can close this one.