search

UdacityAndroidDevScholarship / gis-2k18

This application is a collaborative project made by the Google Udacity Android Developer Scholars.
49 stars 85 forks source link

Updated User Details Activity #89

Closed abanidas closed 6 years ago

abanidas commented 6 years ago

Fixes #56 Enhance #86 I have updated in User Details Activity with the following changes that was asked

  1. My Profile menu item opens edit profile activity.
  2. My Profile menu item is moved to the bottom.
  3. Toolbar UI is updated.
  4. The About Tab UI is updated.
TheRaider commented 6 years ago

@abanidas
Why create a text view and also an edit text for a single item? I think one is enough. When it is editable, you can set the edit text's methods -- setFocusable(true) and setEnabled(true); When it is not editable, you can set the edit text's methods -- setFocusable(false) and setEnabled(false); I think creating a text view and an edit text will result in redundancy. Also, resolve conflicts.

abanidas commented 6 years ago

Yeah, sure @TheRaider . I will make the changes and push it.

abanidas commented 6 years ago

@TheRaider I have made the changes. Please check.

TheRaider commented 6 years ago

@abanidas Nice Work. Thank you for your contribution.