UdacityAndroidDevScholarship / quiz-app

This application is a collaborative project made by the Google Udacity Android Developer Scholars.
96 stars 128 forks source link

discussion screen ui, presenter, view added #126

Closed mdrahil closed 6 years ago

mdrahil commented 6 years ago

Fixes #103

Description

I have implemented the Discussion Screen UI, added Presenter and View also. For now, on clicking home screen quiz items it will navigate to the Help/ Discussion Screen. The discussion screen has only dummy items for now. Once the "load comments and add comment" API will be available from the data layer there are some todo items those need to be implemented. For now please focus on UI only.

Screenshots

AFTER:

image

Other changes

added integer.xml in values added some strings and dimens in values, added some assets in drawable folder.

drulabs commented 6 years ago

@mdrahil this looks great. You have not only implemented the UI but you have followed the current design and created presenter. Awesome work. Even if we select someone else's UI, we will use the presenter and adapter in this PR. Thanks for your contribution.

mdrahil commented 6 years ago

@drulabs thank you for nice comments.

aditisoni8899 commented 6 years ago

@kdhruw Now there is conflict please resolve.

drulabs commented 6 years ago

@aditisoni8899 resolving it now. Please tag @drulabs (personal git handle) not @kdhruw.

aditisoni8899 commented 6 years ago

Resolved @drulabs Have a look

drulabs commented 6 years ago

Looks good @aditisoni8899

aditisoni8899 commented 6 years ago

Merging this PR @drulabs