search

UdacityFrontEndScholarship / quiz-app

This application is a collaborative project made by the Google Udacity Front End Web Developer Scholars.
46 stars 76 forks source link

responsiveness #69

Closed sb39 closed 6 years ago

sb39 commented 6 years ago

issue #65 resolved

ezioda004 commented 6 years ago

You seem to have made many unnecessary changes, for example.

  1. The <section className="main-section"> looked fine the way it is. Revert that back
  2. You have changed the image used in challenge section, please refer to this mockup and use the same image that was there before. Mockup image here
  3. Match the alignments of the section as in the image above. The text section is now smaller than before.

  4. screenshot 73 The text for all section should be above the images.

  5. Remove changes made in Navbar.css, Footer.css, it looks fine the way it was before.

This issue has been open for too long, so you have till evening, 8 o'clock to be precise to do necessary changes or this issue will be assigned to someone else.

sb39 commented 6 years ago

should i close this pull ?

ezioda004 commented 6 years ago

@sb39 No, update this PR. Don't make new ones.

sb39 commented 6 years ago

please verify it's done or not

sb39 commented 6 years ago

@ezioda004 can you tell, what you mean by the text over image, is it like the first div or you mean to tell, the (first text block and then pic block) * 3 ?

ezioda004 commented 6 years ago

@sb39 Yes, exactly. First text block and then image.

sb39 commented 6 years ago

is it ok now ?

git1

ezioda004 commented 6 years ago

@sb39 Yes, thats fine. There should be a section separator though. Also, make sure that on browsers full width, the text and image width ratio matches same as in the mockup. It was like that before so whatever changes you've made, should revert those back.

sb39 commented 6 years ago

all issues have been resolved

sb39 commented 6 years ago

layout updated according to mock