Update Readme - Githubissues

UdacityMobileWebScholarship / guess-quote

This application is a collaborative project made by the Google Udacity Mobile Web Specialist Scholars.

MIT License

22 stars 48 forks source link

Update Readme #4

Closed retrocausal closed 6 years ago

retrocausal commented 6 years ago

Add Basic pre PR checks and balances to be upheld by contributors
By letting them know of upstreams and fetches and subsequent PRs

varundevpro commented 6 years ago

Good :+1:

twishasaraiya commented 6 years ago

In installation steps, we don't need to do npm i after cd GuessTheQuote. Because npm start will automatically start installing the dependencies. We just need to run npm start

retrocausal commented 6 years ago

Ah! Wasn't a change I introduced in the PR though.

But would a user need packages installed at all?

edit: gotcha!

I see

    "start": "npm i && cd ./client/ && npm i && cd ../ && cd ./server/ && npm i && cd ../ && npm run dev",

So, yeah! npm start would suffice. Maybe an owner can edit it instead of a PR for a minor change