search

UdacityMobileWebScholarship / guess-quote

This application is a collaborative project made by the Google Udacity Mobile Web Specialist Scholars.
MIT License
22 stars 48 forks source link

Module pattern #46

Closed deveshjadon98 closed 6 years ago

deveshjadon98 commented 6 years ago

Added a new index.js file with every component to allow developers to import components like import SampleComponent from '../SampleComponent'; instead of import SampleComponent from '../SampleComponent/SampleComponent';

This pattern allows us to make modules of the components in future.

anantoghosh commented 6 years ago

@deveshjadon98 Please do not commit package-lock.json files with this PR.

deveshjadon98 commented 6 years ago

Adding it to gitignore

anantoghosh commented 6 years ago

@deveshjadon98 package-lock.json is needed in the repo, we cannot git ignore it. You just have to remove the package-lock.json files from the commits, leave gitignore as it is. If you need help on how to do this, feel free to ask me.

deveshjadon98 commented 6 years ago

@anantoghosh sure, i will make sure to not commit package-lock.json.

deveshjadon98 commented 6 years ago

Changes done, please check.

skyshader commented 6 years ago

@deveshjadon98 I hope you made sure things are working as they were before :) Please acknowledge and I will merge this PR.

deveshjadon98 commented 6 years ago

@skyshader yes i have, i tried using SampleComponent in App it worked fine.

skyshader commented 6 years ago

Reverted this since it breaks the build. @deveshjadon98 please check once before acknowledging for future PRs.