search

UdacityMobileWebScholarship / guess-quote

This application is a collaborative project made by the Google Udacity Mobile Web Specialist Scholars.
MIT License
22 stars 48 forks source link

Logout route added #59

Closed sounak07 closed 6 years ago

sounak07 commented 6 years ago

Implemented logout route by deleting token from the database.

ayushdev commented 6 years ago

@sounak07 Always make PR to the develop branch, not to master. Feel free to make another PR

sounak07 commented 6 years ago

But I selected develop while putting the PR. I don't know how the PR what made in master.

ayushdev commented 6 years ago

@sounak07 I think you cloned the master branch, instead of develop branch and made changes in that. Clone the develop branch this time.

sounak07 commented 6 years ago

What I did is I fetch the upstream I merged by master branch with develop branch of upstream Like git merge upstream/develop Then I made the changes Was it a wrong process?? @ayushdev

twishasaraiya commented 6 years ago

@sounak I think you are still in the master branch. Perform git checkout develop to switch to develop branch and then make the changes. All your current changes have been made in master branch of forked repo. Also please go through the correct steps in Feature Development