UdacityMobileWebScholarship / guess-quote

This application is a collaborative project made by the Google Udacity Mobile Web Specialist Scholars.
MIT License
22 stars 48 forks source link

Added QuoteNOption Component #67

Closed suhasbansude closed 6 years ago

suhasbansude commented 6 years ago

Added QuoteNOption Component. We need to enhance UI and Animations.

image

twishasaraiya commented 6 years ago

@suhasbansude Thank you for PR. Please go through our UI Designs and make appropriate changes. Also please add proper commit messages so that it becomes easier to understand like quote and option component added

twishasaraiya commented 6 years ago

@suhasbansude Can you please add a screenshot here??? It becomes easy for us to review. And please add the following

  1. Create a new page as follows /pages/Quiz which will contain a) Quiz.js b) index.js c) Quiz.css
  2. Add a route to the page /RouteManager
  3. Call the QuoteNOptionContainer from the Quiz page
suhasbansude commented 6 years ago

capture

twishasaraiya commented 6 years ago

@suhasbansude As I said earlier, Please go through our UI Designs. The color scheme in UI Design is different from what you have used. Also use green-tick.svg and red-cross.svg for answers and not star.svg. Once that is done the PR is ready to be merged.

If You have any doubts please let me know.

twishasaraiya commented 6 years ago

Also due to new PR merged, there are merge conflicts now, so please first merge existing develop with your local copy to resolve the conflict.

twishasaraiya commented 6 years ago

Hey, @suhasbansude please add screenshot once you have made required changes to the UI. The PR is almost ready to be merged.

suhasbansude commented 6 years ago

@twishasaraiya ok I am currently working on UI.

suhasbansude commented 6 years ago

Please check New UI Related changes capture1 capture2 capture3

twishasaraiya commented 6 years ago

@suhasbansude Great work 👍. Thank so you much. Some changes would be required when linked to the backend but merging it now.