UdacityMobileWebScholarship / showcase-app

This application is a collaborative project made by the Google Udacity Mobile Web Specialist Scholars.
13 stars 30 forks source link

WIP: Server setup #29

Closed ritikrishu closed 6 years ago

ritikrishu commented 6 years ago

Fixes #26

Checklist

Changes proposed in this pull request:

This is initial firebase setup for client static hosting and server dynamic routes handlers. Server is a simple express app with two example handlers, cahched handler has an active CDN that caches the data from 10 mins, non-cached-handler shows fresh data without any caching. These are just example handlers to show how we need to put other stuff in there. client/build folder is uploaded as static assets and root serves index from there. https://showcase-app-6aace.firebaseapp.com/

Blockers:

I can't get CRA to stop generating service worker (even after commenting the import state in index.js). For this deploy, I've removed that manually after generating build files. If someone from the team or community can help with overriding the fetch handler from generated service worker..that would be great. Also will help finishing this up!

Other notes: Will update docs on the PR soon. This is still work in progress.

kanlanc commented 6 years ago

@ritikrishu could you explain the problem more?

ritikrishu commented 6 years ago

@highskillzz I want the create react app to generate a bundle either without service worker or even better if I can edit the fetch handler in the final generated service worker.

ritikrishu commented 6 years ago

closing this PR for now, will make another one from the current architecture