search

UdacityMobileWebScholarship / showcase-app

This application is a collaborative project made by the Google Udacity Mobile Web Specialist Scholars.
13 stars 31 forks source link

Need of Continuous Integration services #4

Open palnabarun opened 6 years ago

palnabarun commented 6 years ago

This is really needed to check the code quality pushed by the contributors, be it code or documentation. Travis CI can be used for the purpose.

palnabarun commented 6 years ago

I have the idea about setting up Travis but not much idea about tests in the Javascript/React world.

@divyamrastogi @ritikrishu Please provide your inputs.

divyamrastogi commented 6 years ago

@palnabarun: I can handle the unit tests.

palnabarun commented 6 years ago

Great. :)

Please also link some articles here which lets new contributors know about unit testing in ReactJS.

realslimshanky commented 6 years ago

@divyamrastogi we have few tests written by CRA as well. You might wanna include them as well. https://github.com/UdacityMobileWebScholarship/showcase-app#running-tests Also, I'm assigning you to this issue.

divyamrastogi commented 6 years ago

@realslimshanky : That's the plan, they've got a few examples already. I'll include some good tutorials for writing unit tests as well, so that everyone who's going to be writing components will be able to write unit tests for them.

kanlanc commented 6 years ago

So where can we find the individual components that we need to code?

ritikrishu commented 6 years ago

@highskillzz soon you'll find issues for modules and components. Once we finalize the designs we'll be flooding those out to you, so you might want to keep an eye🔭 on #5

nikitasharma2692 commented 6 years ago

We can use SonarQube , https://www.sonarqube.org/ for the code smells , vulnerability in the code, unused imports , code coverage.

nikitasharma2692 commented 6 years ago

I can work upon linking that to project if it is not added yet

palnabarun commented 6 years ago

@nikitasharma2692 Let us first get a basic Travis setup working. Then we can add other integrations.

deveshjadon98 commented 6 years ago

@divyamrastogi are we using Jest and Enzyme for testing our components?

divyamrastogi commented 6 years ago

We'll be using Jest, since Facebook is the one who created it., forit Testing. Travis CI will be our CI tool.

ParthS007 commented 6 years ago

@divyamrastogi I can help you in setting up of Travis CI and Codecov(for code coverage).

ParthS007 commented 6 years ago

@divyamrastogi We can also add codacy for checking the quality of PR.

divyamrastogi commented 6 years ago

All right, I'll definitely look at all these options and we'll cover all the bases. Unit Testing, E2E, Code Coverage are the ones we'll start with. Let's do this on Sunday evening. By then we will have a few components to start coding, hopefully.

gpalsingh commented 6 years ago

It'd be a good idea to ask the people who add new features to provide unit tests for the same.

realslimshanky commented 6 years ago

@divyamrastogi any update on this issue?

divyamrastogi commented 6 years ago

I'll make a few components of our design and add unit tests for them by tomorrow. That should serve as a guideline.