UdacityMobileWebScholarship / showcase-app

This application is a collaborative project made by the Google Udacity Mobile Web Specialist Scholars.
13 stars 31 forks source link

Create required UI components for the front-end #46

Open blenderskool opened 6 years ago

blenderskool commented 6 years ago

I'm submitting a ...

Current behavior:

As of now, most of the issues are open to other developers on per-layout basis. Since the app uses fundamental components throughout the app, every page may end up having different styles for every component which makes it really cumbersome to manage.

Expected behavior:

We can first create the fundamental components required in the app. This would allow other developers to join in and quickly create the layouts based on the desings. I am ready to start working on this :slightly_smiling_face:

anurag-majumdar commented 6 years ago

@blenderskool This is quite an important task indeed. Will you be carrying this feature out by yourself or you would like one more person to join in with you? If you need help I can assist you with these fundamental components. :smiley:

blenderskool commented 6 years ago

@anurag-majumdar Yes, even you can contribute. Based on some component guidelines that I have added to the albums, we can divide the components between ourselves.

realslimshanky commented 6 years ago

@blenderskool if this is the case, one has to create UI components. And then those components can be used by other contributors for layout development. Inversely, since we have fixed views, those views can be designed individually to each other. Since we have very few time left till the end of the course we should have a working model. In future if we get time we can unify similar components. What do you guys think? @divyamrastogi @PrabhanshuAttri @palnabarun @shubhshrma @ParthS007 @ritikrishu

divyamrastogi commented 6 years ago

I actually agree with @blenderskool because it's not that hard to identify reusable components. Believe me, it saves a lot of time if you think ahead and plan these things a little.

In fact, even the layout can be a component since we've got a similar structure of the header section and the rest of the page. Let me identify these components and I'll create issues for them. Then, we can reuse those components to pick up issues created by @realslimshanky. What say?

realslimshanky commented 6 years ago

@divyamrastogi great. Thanks for taking such a huge task. Would help a lot in future processes.

blenderskool commented 6 years ago

@realslimshanky @divyamrastogi I have already added some in-depth component guidelines here https://photos.app.goo.gl/5nm1W01LSmGwOfGh2 Additional components can be created based on these principles

anurag-majumdar commented 6 years ago

Guys, before we dive in to the components part, we need to also add that we are changing the version from latest material-ui to the stable one 0.20. I am working on this part and will issue a PR soon.

The UI layouts are going to use 0.20 version of material-ui.

anurag-majumdar commented 6 years ago

Please ignore the last comment regarding 0.20. We are continuing with material-ui@next. Are the reusable components in place? Then we can start building the pages asap.

@divyamrastogi @blenderskool @realslimshanky @PrabhanshuAttri @palnabarun