search

UdaraJay / Pile

Desktop app for digital journaling.
https://udara.io/pile
MIT License
2.03k stars 109 forks source link

Bug: preview generating empty img tag #24

Open khakimov opened 11 months ago

khakimov commented 11 months ago
image

generating empty img tag

<img class="CK_hcajY7MNfGQs9RENC" src="">

from here:

https://github.com/UdaraJay/Pile/blob/2ee06875fe86a0e645eb79e645f29f124fce8d5b/src/renderer/pages/Pile/Editor/LinkPreviews/LinkPreview/index.jsx#L85-L90

easiest way to {image && <img src={image} />}, but showing nothing maybe not the option. Shall we use a pre-set icon(s) for empty/null case...?

UdaraJay commented 10 months ago

I noticed this too! I think link icon makes sense in place. feel free to PR it, otherwise I'll fix in the future.