Udayraj123 / OMRChecker

Evaluate OMR sheets fast and accurately using a scanner 🖨 or your phone 🤳.
MIT License
784 stars 324 forks source link

[Enhancement] Allow skipping crop if page boundary is not visible in CropPage #215

Open Udayraj123 opened 1 month ago

Udayraj123 commented 1 month ago

Is your feature request related to a problem? Please describe. In case of combined CropPage + CropOnMarkers usecase, sometimes the page boundary is not visible but the markers can still be detected. Currently in this case CropPage raises an error for the image since it thinks the image is not fit for processing further.

Describe the solution you'd like We should allow a flag shouldFailIfPageNotFound which would be set to true by default. On setting it as false, the CropPage processor should return the input image without cropping.

Describe alternatives you've considered Another alternative is to create a new processor that does this instead of a flag, but seems unnecessary as of now.

Additional context

Prasadayus commented 1 month ago

Hi @Udayraj123 I want to work on this

Udayraj123 commented 1 month ago

@Prasadayus Sure, you can share a basic approach and i'll assign it to you

palash018 commented 4 weeks ago

@Prasadayus Are you actively working on this? else i'd like to move forward with this issue