search

Udayraj123 / OMRChecker

Evaluate OMR sheets fast and accurately using a scanner 🖨 or your phone 🤳.
MIT License
784 stars 324 forks source link

Added a Bulk Image Convertor function #225

Closed Anushlinux closed 1 month ago

Anushlinux commented 1 month ago

I have created a convertor.py file in which i have added the conversion logic which converts any png image to jpeg or jpg or tiff and vice-versa

Pls review the code and let me know

Udayraj123 commented 1 month ago

Hey @Anushlinux, thanks for raising the PR for image conversion. Just one problem, you'd need to port this code onto the dev branch first. And in terms of code structure, you can follow what's added in the scripts/local folder instead of src since src will contain some code that is used directly when running OMRChecker.

Please check this comment and update your PR on top of the dev branch if possible. https://github.com/Udayraj123/OMRChecker/issues/213#issuecomment-2384792875

After that can you also check the scripts/hooks/convert_images_hook.py file in dev and see if we can import your function in that hook to have the same functionality?