UdelaRInterior / ansible-role-jitsi-meet

Installs the Jitsi Meet open source videoconferencing software
17 stars 9 forks source link

[FEATURE/QUESTION] Change disable variable to enable #15

Closed tabacha closed 4 years ago

tabacha commented 4 years ago

Is your feature request related to a problem? Please describe.

I think it is not good style to name boolean variable in a negative meaning like this:

jitsi_meet_disable_third_party_requests: true

it is confusing to the admin/user because he must set it to true to disalbe a feature.

I suggest to change all variable name to th positiv menaing, for example:

jitsi_meet_enable_third_party_requests: false

On the other side, a user see a setting in a howto and perhabs did not find it in our ansible role if it is named different.

This will affect the follwoing names / suggested new name:

santiagomr commented 4 years ago

I agree that the name of the variables makes you think twice before choosing the desired value.

I like all the names you suggest. Respecting the default values with which Jitsi Meet is installed, any improvement in intuitiveness is welcome.

Do you want to send a PR with them?

tabacha commented 4 years ago

HI @santiagomr I will perpare a PR soon

santiagomr commented 4 years ago

Thanks for sending the PR (#17), it's already merged into master