UdelaRInterior / ansible-role-jitsi-meet

Installs the Jitsi Meet open source videoconferencing software
17 stars 9 forks source link

[BUG] Some variables have no effect #20

Closed pat-s closed 4 years ago

pat-s commented 4 years ago

Thanks for this role!

While deploying a jitsi instance, I found out that the following variables have no effect with v4.0:

Also some work on FF but not on Chrome.

No big deal in the end, just wanted to let you know.

santiagomr commented 4 years ago

Thanks for the report, I'm going to check it

santiagomr commented 4 years ago

@pat-s, I tried it just in case and all the variables are having effect.

I think you don't notice the impact, because you have the variable jitsi_meet_customize_the_ui set in false (default value), and in this way all the ui_customization.yml tasks are skipped

- include: ui_customization.yml
  tags: jitsi_ui
  when: jitsi_meet_customize_the_ui | bool

This is correct? It's in these tasks and templates where the variables you mention will actually be used.

pat-s commented 4 years ago

This is correct? It's in these tasks and templates where the variables you mention will actually be used.

Indeed! I had it set to false 🤦

Sorry for taking your time with this one 🙏

santiagomr commented 4 years ago

No problem. Better something doubly checked than an unreported error.