Open UdhayaShan1 opened 7 months ago
Refer to #1356. This is just referring to error messages.
[The team marked this bug as a duplicate of the following bug]
Inconsistent out of bounds
INDEX
errorFor list of 9 people,
edit 21321312131232132132132132131313123 n/wdad
returnsand
edit 2323 n/wdad
returnsIt should be the same out of bounds expected error.
This is separate from negative index issue as they are not fixed the same way.
[original: nus-cs2103-AY2324S2/pe-interim#1717] [original labels: severity.Low type.FeatureFlaw]
[This is the team's response to the above 'original' bug]
Hi thanks for the catch!
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: I wished the team would provide better justification as to why this was a duplicate of another issue I flagged where I mentioned below "This is separate from negative index issue as they are not fixed the same way." to bring in some possible discussion with the dev team.
To why I believe this was not an issue,
All the team mentioned was "Refer to #1356. This is just referring to error messages.". This is too generic and not acknowledging if they understood the difference.
This issue raises the point on negative index raising a generic invalid command. (Negative Index error)
The parent issue which they believe is a duplicate raises the error why a very large integer gives an different error than another out of bounds integer where it should be the same. (Out of bound error)
Both are separate issues that are fixed by separate code changes
edit -1 n/wdad
as expected is a negative index. But it simply returnsYes while the INDEX (must be a positive integer) is there, this is not the focus of the error message. It prints invalid command first and the correct format indicating a generic invalid message.
Error message should be more specific.