Open UdhayaShan1 opened 7 months ago
Refer to #3518.
[The team marked this bug as a duplicate of the following bug]
Over-zealous rejection of phone input (disallowing users from having the same phone number)
Enter "add n/John Doe4 p/ 123456 e/qwertyuiopasdfghjklzxcvbmqwertyuiopasdfghjklzxcvbmqwertyuiopasdfghjklzxcvbmqwertyuiopasdfghjklzxcvbmqwertyuiopasdfghjklzxcvbmqwertyuiopasdfghjklzxcvbmqwertyuiopasdfghjklzxcvbmqwertyuiopasdfghj@example.com a/01/01/2024 a/02/01/2024 t/friends t/owesMoney", which is a person contact with the same phone number as "4. JohnDoe3", and the input is rejected.
However, 2 young volunteers from the same family might have registered under their parent's phone number. Blocking that input might not add any value but allowing it does. As this is a rare situation, the severity has been indicated as VeryLow.
A quick fix would be to revert back to the original AB3 which allows for duplicate phone numbers.
[original: nus-cs2103-AY2324S2/pe-interim#2920] [original labels: type.FeatureFlaw severity.VeryLow]
[This is the team's response to the above 'original' bug]
Thanks for the catch.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: [replace this with your explanation]
I believe we should not check for
PHONE
duplicates. As it may be possible for people to have the same number especially if someone was using a prepaid number which is then used by another.A improvement is to check duplicates based on
EMAIL
whereEMAIL
makes sense to be duplicate flagged as its less likely to create the same email address.