UdhayaShan1 / pe

0 stars 0 forks source link

[DG] Length Limit enhancement has too many overlaps #19

Open UdhayaShan1 opened 2 months ago

UdhayaShan1 commented 2 months ago

image.png

This tackles PHONE and EMAIL which are two separate fixes in code. Hence, it should not be grouped under one enhancment.

soc-pe-bot commented 2 months ago

Team's Response

Refer to #2122 on overlaps of planned enhancements.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

[DG] Special Characters Enhancement has too many overlaps, leading to lesser possible flagging of FFs

image.png

While, its a valid enhancement, I do not believe this should be just one. It takes many code changes to several function to fix the many different fields that do not accept symbols.

For example, NAME should accept symbols is one enhancement on its own.

This prevents me from flagging out potential feature flaws for multiple fields.


[original: nus-cs2103-AY2324S2/pe-interim#2694] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi thanks for the catch. We believe that flagging these feature flaws will be of low severity, hence we have decided to classify this as low severity.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is no way duplicate of #2122 (which is another issue I flagged).

2122 tackles another enhancement, #3, that overlaps many fields and these fields are to accept symbols in future.

This issue, enhancement #4, tackles length limits of three different fields which are separate code changes from accepting symbols.

Hence they are disjoint enhancements.