UdhayaShan1 / pe

0 stars 0 forks source link

Missing compulsory fields not shown when we are missing fields #5

Open UdhayaShan1 opened 2 months ago

UdhayaShan1 commented 2 months ago

While yes, the UG makes it clear what fields are compulsory, suppose I add a subset of those fields, I am no longer sure what i am missing.

image.png

add n/Denzel is the right format but incomplete, I am unable to add Denzel. So I am not sure if this is because I am missing on some fields, hence I am unclear which fields am I supposed to add.

This should be shown in the error message as well which just shows a generic invalid command making it unspecific, hence a FF.

image.png

For eg. my error message should print to me that I am missing out on email and phone at least instead of trying to guess if I am missing something. This is a good feature if we are extending and adding more fields.

nus-se-bot commented 2 months ago

Team's Response

Hi it is stated clearly in the user guide that n/PHONE and e/EMAIL are compulsory fields to be added, therefore there's no need to guess what is missing. Just by specifying n/NAME is insufficient.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Team's response missed the point of the report and did not acknowledge their generic error message.

I mentioned 'add n/Denzel is the right format but incomplete', yes the command is incomplete because I am missing fields as I have again mentioned "it clear what fields are compulsory, suppose I add a subset of those fields". So yes here I am missing PHONE and EMAIL. But error just says Invalid Command Format. This is too generic hence a FeatureFlaw

image.png

I am expecting something like this a more specific error (from my product to take as an example),

image.png

This clearly tells me where I went wrong.

I believe to reject this report and not acknowledge some merit is wrong.