UdhayaShan1 / pe

0 stars 0 forks source link

Unclear error messages when there are multiple wrong fields #9

Open UdhayaShan1 opened 2 months ago

UdhayaShan1 commented 2 months ago

add n/wdadad p/9021 5365 e/ud+-@gmail.com has two wrong fields

Email should not have consecutive symbols and number should not have spaces.

However, system replies just image.png

It should show all errors present so we are able to rectify, here I should also see a error message for email field hence making the current error rather generic.

nus-se-script commented 2 months ago

Team's Response

We believe this shouldn't be an issue. The current implementation helps the user to fix the errors one by one. For your case fixing the p/PHONE field will result in the error message subsequently tell you that the e/EMAIL field is wrong in which you then can proceed to fix it.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: To reject this issue means the current implementation is expected and correct behaviour and not acknowledging my issue's merit.

I will give concession if this documented in any way, but this explanation "The current implementation helps the user to fix the errors one by one." is the first time I am seeing it, which is not in the UG and product.

Furthermore, I believe my issue is an FeatureFlaw as we are unable to see what the errors are and we have a generic (incomplete) error that only shows error for just one field.

I expect something like

image.png

Which is reasonable for a CLI command based application that should tell the user what fields they can fix instead of one-by-one fixing and seeing one-by-one which fields are wrong.

Since there is possible room for improvement to fix this generic command error message, I do not think this should be rejected.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** I disagree, this is not a cosmetic issue in any way. ![image.png](https://raw.githubusercontent.com/UdhayaShan1/pe/main/files/cd78940b-92f6-46e2-bb29-13687fd40e3e.png) This is at least a FeatureFlaw by ![image.png](https://raw.githubusercontent.com/UdhayaShan1/pe/main/files/213f6b36-1bd8-49f9-8192-6e654d12a476.png) Hence, it should be at least a `Low`.