UedaTakeyuki / mh-z19

Read CO2 concentration from mh-z19 sensor on the Raspberry Pi & handle it. Detect Raspberry Pi model automatically and read the value from an appropriate serial device.
MIT License
182 stars 37 forks source link

Refactor the package #20

Closed vava24680 closed 4 years ago

vava24680 commented 4 years ago

In this PR, I have done the following changes:

UedaTakeyuki commented 4 years ago

Thank you for your great works on this repository. I can see these works are fine, modern, good professional manner works. I'm moving and filling to prise your great works.

Unfortunately, there is a lot of interface breaking change, this is the cause of this **rejection of your pull request". There are already many users of this library in the world. I really appreciate these users and respect their situation to use.

For example, all() feature is requested by one of these users, so we should respect this request, keep it to remain. Python2 interface is also, I can't find any reasonable reason to abandon an environment that is using python2 still.

I hope you get to use this library and to like also. In case there are some pieces of stuff to block your using, the change to fix it must be reasonable to accept. To say frank, I can't find any change which needs some of these, on the contrary, all of your change seems to just refactoring which helps no new user who is stacking to use this now. I hope you tell me your reason to block your using and really welcome your pull request just fixing your stacking issue to use this without any refactoring. Thank you for your respect for the community.