Closed vava24680 closed 4 years ago
Thank you for your great works on this repository. I can see these works are fine, modern, good professional manner works. I'm moving and filling to prise your great works.
Unfortunately, there is a lot of interface breaking change, this is the cause of this **rejection of your pull request". There are already many users of this library in the world. I really appreciate these users and respect their situation to use.
For example, all() feature is requested by one of these users, so we should respect this request, keep it to remain. Python2 interface is also, I can't find any reasonable reason to abandon an environment that is using python2 still.
I hope you get to use this library and to like also. In case there are some pieces of stuff to block your using, the change to fix it must be reasonable to accept. To say frank, I can't find any change which needs some of these, on the contrary, all of your change seems to just refactoring which helps no new user who is stacking to use this now. I hope you tell me your reason to block your using and really welcome your pull request just fixing your stacking issue to use this without any refactoring. Thank you for your respect for the community.
In this PR, I have done the following changes:
argparse
dependency and use the one provided by the Python 3 Standard Library--all
since this functionality does not show up in the Chinese version data sheet nor the English version data sheet, so I removed it to prevent the misusingRPi_MH_Z19B
to encapsulate all the functions, in this way, it can also be used a dependency in another project or packageconst
module, which makes it more readable.start_getty
and thestop_getty
functions since I think both of them is unnecessary if the TX and the RX pins are connected a MH-Z19B sensor, the getty should not work on those two pins