UffizziCloud / uffizzi

Build self-serve developer platforms in minutes, not months with out-of-the-box Kubernetes multi-tenancy, virtual clusters, cloud-based dev environments, customizable templating, and more.
https://uffizzi.com
Apache License 2.0
324 stars 25 forks source link

Adjust Terminated status processing. #125

Open 7R41N33 opened 2 years ago

7R41N33 commented 2 years ago

When a pod has Terminated status a preview should not considered as failed.

Repo for testing this issue: https://github.com/axisofentropy/uffizzi_chaos

zipofar commented 2 years ago

Same task for platform https://github.com/UffizziCloud/uffizzi_platform/issues/16

zipofar commented 2 years ago

How to TEST:

  1. Launch ufffizzi core (uffizzi_app). Does not forget add MANAGED_DNS_ZONE_DNS_NAME: "example.uffizzi.com" to compose file
  2. Launch uffizzi controller
  3. Launch uffizzi cli docker-compose run --rm gem bash

Use this docker-compose.uffizzi.yaml for create preview bundle exec uffizzi preview create docker-compose.uffizzi.yaml

services:
  chaos:
    image: dbpterraform2/uffizzi_chaos_exit_until_nginx

  web:
    image: nginx

x-uffizzi:
  ingress:
    service: chaos
    port: 80

  continuous_preview:
    share_to_github: true
    delete_preview_after: 1h
    delete_preview_when_pull_request_is_closed: true
    deploy_preview_when_pull_request_is_opened: true

Result should be: Screenshot 2022-06-08 at 17 04 41

uffizzi_chaos_exit_until_nginx should not be failed

AnnaPochepina commented 2 years ago

tested

NealArw commented 2 years ago

TESTED on prod - OK

# uffizzi preview create compose.yml
Preview created with name deployment-5
[✔] Creating containers...
Done
[⠇] Deploying preview...
  [⠋] uffizzi_chaos_exit_until_nginx
  [✔] nginx