Looks good!
I've added 2 commits of my own (let's ignore the third...).
First one makes sure the tests actually pass on GitHub as well; by default we don't have compiled i18n in the repo's, so the tests were failing because it couldn't apply the translation. Now we compile the i18n files before we start the test.
Second commit is just a small refactor to move the result codes into an Enum like class. Not really relevant to this PR specifically, but I think the code is a bit cleaner this way.
Looks good! I've added 2 commits of my own (let's ignore the third...).
First one makes sure the tests actually pass on GitHub as well; by default we don't have compiled i18n in the repo's, so the tests were failing because it couldn't apply the translation. Now we compile the i18n files before we start the test.
Second commit is just a small refactor to move the result codes into an Enum like class. Not really relevant to this PR specifically, but I think the code is a bit cleaner this way.