Closed bbonf closed 2 years ago
I like the new upload views; it's better than my mockup!
One last point; we might want to look into auto-closing the experiment if all groups are full. That way, the jspsych-utils' code that checks if the experiment is closed will trigger correctly.
Overall I think it looks good. But in my usual fashion, I managed to find some things I'd like to see different. Keep in mind that it is just my opinion, you're absolutely free to disagree in which case I will yield ;) (Unless I really really really feel very strongly about it, but that almost never happens :P)
There is one more general issue I'd like to bring up. I think it might be better to split up the UploadView into separate views with a common base class for both the session and the non-session endpoints. The current view is more complicated due to the two scenario's, so splitting it up would make the code path that is being taken more straightforward (and thus easier to understand).
I've made a small example, which needs to be cleaned up a bit still. If you agree, I can finish it properly and commit it to this branch if you want.
PS: Dr. Guido, or: how I learned to stop worrying and love the walrus operator