search

UiL-OTS-labs / web-experiment-datastore

Other
0 stars 0 forks source link

First steps to saving with subject id #39

Closed maartenuni closed 2 years ago

maartenuni commented 2 years ago

Saving would better have been named downloading :-).

Probably I need to do some extra work before this is ready to merge in to the develop branch.

tymees commented 2 years ago

I think you forgot to commit a migration file

bbonf commented 2 years ago

I'm afraid we missed something in this PR. Experiments now have a default group, but ParticipantSession.group remained nullable. And ParticipantSessions are created without a target group in UploadView: https://github.com/UiL-OTS-labs/web-experiment-datastore/blob/0869a39b0e7c4163670d5c3667f23ba8fe30cfbb/api/views.py#L121

This is not too bad, but it means that the completion counter for the default group remains on 0