search

UiO-CS / tf-wavelets

TensorFlow implementation of descrete wavelets transforms
MIT License
49 stars 11 forks source link

cyclic_conv1d_alt different result #1

Open wallneradam opened 5 years ago

wallneradam commented 5 years ago

Hi,

I'm playing with your library and tried to get the same results as PyWavelets' dwt/idwt functions. I got totally different ones. I found that you have 2 version of cyclic_conv1d, and cyclic_conv1d_alt is used in dwt1d and idwt1d. If I change it to the normal (not "_alt" suffixed version), I get the same results as PyWavelets.

My question is, what is this "_alt" version good for, why it is used instead of the "normal" one? And is it normal to get different results from them?

Thank you for your work on this library, it is very useful!

mathialo commented 5 years ago

Hello!

They are intended to be the same, the _alt version was implemented as an easier-to-maintain alternative following an easier idea for periodic extensions for the convolutions, so what you have found is definitely a bug.

Could you post details on your input and how you achieve the different results? That could be very useful for debugging.

Thanks a lot for your feedback!