UiPath / CoreWF

WF runtime ported to work on .NET 6
MIT License
1.13k stars 217 forks source link

Any way of getting the migration of System.Activities.DynamicUpdate #99

Closed casbelt closed 4 years ago

casbelt commented 4 years ago

Hello,

I am in the middIe of a migration to net core and I am trying to get a class from DynamicUpdate spacename (NativeActivityUpdateMapMetadata) I have installed the nuget package Core.Wf in my project but when I try to access to DynamicUpdate namespace it does not appears to be chosen.

image

Am I doing something wrong?

Thanks in advance!

lbargaoanu commented 4 years ago

Why do you need that?

casbelt commented 4 years ago

Hi, I am trying to override a method from the class NativeActivity, "OnCreateDynamicUpdateMap"

image

The method receive as first argument a NativeActivityUpdateMapMetadata class which belongs to DynamicUpdate namespace. I don´t know how to replicate this class in net core.

Thanks again

lbargaoanu commented 4 years ago

So you're really using dynamic update. That's an advanced feature we're not ready to port at this time. We're trying to reduce the scope of this project.

dmetzgar commented 4 years ago

@casbelt dynamic update is only used for upgrading persisted instances from an older workflow version to a newer one. The feature is fairly complex and quite rarely used so it's been left out of CoreWF. Although if you really need it, we'd appreciate a PR.

lbargaoanu commented 4 years ago

@dmetzgar Even that seems tricky. The way that was implemented it was tightly coupled to the base class Activity. I wouldn't want that now. I would expect the implementation to live in the higher level package, UiPath.Workflow, not in the core package. So it wouldn't be a straightforward port.

lbargaoanu commented 4 years ago

Just to be clear, I did previously port dynamic update and then removed it again yesterday in #100.

casbelt commented 4 years ago

Hello, it´s a pity.

Thanks for your time and dedication.

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.