UiPath / Infrastructure

42 stars 61 forks source link

UiPath orchestrator AWS template default parameter QSS3KeyPrefix must be quickstart-uipath-orchestrator not quickstart-uipath-robot #110

Open obriensystems opened 3 years ago

obriensystems commented 3 years ago

Describe the bug Running the default AWS deployment for full HA fails by default on the nested orchestrator template because the default s3 template variable references quickstart-uipath-robot instead of *-orchestrator - causing a CF failure on the 2nd nested template creation

Product and Cloud Latest default UiPath template with new VPC in https://aws-quickstart.github.io/quickstart-uipath-orchestrator/#_launch_the_quick_start

Expected behavior Template should run to completion - it fails

Additional context in https://aws-quickstart.github.io/quickstart-uipath-orchestrator/#_launch_the_quick_start via https://github.com/UiPath/Infrastructure specifically https://github.com/UiPath/Infrastructure/blob/main/AWS/Orchestrator/templates/main.template.yaml#L983

without the orchestrator change/ for

2021-04-14 19:20:35 UTC-0400 OrchestratorStack CREATE_FAILED S3 error: The specified key does not exist.

"finding key" https://github.com/UiPath/Infrastructure/blob/main/AWS/Orchestrator/templates/main.template.yaml#L983

OrchestratorStack: Type: 'AWS::CloudFormation::Stack' Properties: TemplateURL: !Sub

S3 URL: https://aws-quickstart.s3.us-east-1.amazonaws.com/quickstart-uipath-orchestrator/templates/main.template.yaml

using

QSS3BucketName = aws-quickstart

QSS3BucketRegion = us-east-1 QSS3KeyPrefix = quickstart-uipath-robot/ (change to quickstart-uipath-orchestrator/

should be (works) https://aws-quickstart.s3.us-east-1.amazonaws.com/quickstart-uipath-robot/templates/uipath-orchestrator.template.yaml

should be https://aws-quickstart.s3.us-east-1.amazonaws.com/quickstart-uipath-orchestrator/templates/uipath-orchestrator.template.yaml

continuing/rerun

2021-04-14 20:48:01 UTC-0400 UiPath-Orchestrator CREATE_COMPLETE -
2021-04-14 20:47:58 UTC-0400 OrchestratorStack CREATE_COMPLETE -
2021-04-14 19:44:41 UTC-0400 OrchestratorStack CREATE_IN_PROGRESS Resource creation Initiated
2021-04-14 19:44:40 UTC-0400 OrchestratorStack CREATE_IN_PROGRESS -
2021-04-14 19:44:38 UTC-0400 NetworkStack CREATE_COMPLETE -
2021-04-14 19:41:34 UTC-0400 NetworkStack CREATE_IN_PROGRESS Resource creation Initiated
2021-04-14 19:41:33 UTC-0400 NetworkStack CREATE_IN_PROGRESS -
2021-04-14 19:41:26 UTC-0400 UiPath-Orchestrator CREATE_IN_PROGRESS User Initiated

start 1941 HA slaves up 1945 bastion up 2045

AndreiBarbuOz commented 3 years ago

thanks @obriensystems, the issue comes from this default value: https://github.com/UiPath/Infrastructure/blob/ebfea9828e16ea7c0b807625e9784d651cb0965e/AWS/Orchestrator/templates/main.template.yaml#L934

which needs to be replaced with quickstart-uipath-orchestrator

obriensystems commented 3 years ago

replaced/verified in https://github.com/obrienlabs/uipath/blob/main/cloudformation/templates/main.template.yaml#L947