UiPath / Infrastructure

42 stars 60 forks source link

Email validation AWS main.template does not handle new TLD domains like .global (size hardcoded to 5) #114

Open obriensystems opened 3 years ago

obriensystems commented 3 years ago

Describe the bug Email validation on main template does not handle new TLD domains like packet.global for example

Product and Cloud Latest UiPath for AWS

Expected behavior dont force .com, .org domain emails

Additional context fix diff --git a/cloudformation/templates/main.template.yaml b/cloudformation/templates/main.template.yaml index 2964428..7494086 100644 --- a/cloudformation/templates/main.template.yaml +++ b/cloudformation/templates/main.template.yaml @@ -834,7 +834,7 @@ Parameters: Description: High-availability add-on user name. Must be a valid email address. Type: String Default: 'michael@packet.global'

obriensystems commented 3 years ago

diff --git a/cloudformation/templates/uipath-orchestrator.template.yaml b/cloudformation/templates/uipath-orchestrator.template.yaml index 83c4b22..757751d 100644 --- a/cloudformation/templates/uipath-orchestrator.template.yaml +++ b/cloudformation/templates/uipath-orchestrator.template.yaml @@ -748,7 +748,7 @@ Parameters: HAAUser: Description: High-aailability add-on user name. Must be a valid email address. Type: String

AndreiBarbuOz commented 3 years ago

to be replaced with:

[a-z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-z0-9!#$%&'*+/=?^_`{|}~-]+)*@(?:[a-z0-9](?:[a-z0-9-]*[a-z0-9])?\.)+[a-z0-9](?:[a-z0-9-]*[a-z0-9])?