search

UiPath / ReFrameWork

Robotic Enterprise Framework Template
MIT License
340 stars 561 forks source link

Put tests execution out of Excel Application Scope #34

Open jestinga opened 3 years ago

jestinga commented 3 years ago

Hello,

I had some issues using the tests features with workflows using Excel applications (for example testing a KillAllProcesses workflow that kills Excel processes)

I edited the workflow to only put "Read Range" and "Write Range" activity into "Excel Application Scope" and it seems to work perfectly.

Does the executions of the tests needs to be in the Excel Application Scope?

Richard5Chan commented 3 years ago

Helloread range and write range have two types1. uses excel application scope as a container2. system that does not use excel application scope as containerThe second type can run on environments without excel application installedOn 28/06/2021, 18:44 jestinga @.***> wrote:

Hello, I had some issues using the tests features with workflows using Excel applications (for example testing a KillAllProcesses workflow that kills Excel processes) I edited the workflow to only put "Read Range" and "Write Range" activity into "Excel Application Scope" and it seems to work perfectly. Does the executions of the tests needs to be in the Excel Application Scope? —You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.

jestinga commented 3 years ago

Thanks for your answer.

I may have not been very clear.

The issue I encountered was that all the executions of tests are done within an Excel Application Scope (by default). So during the execution of tests the file "Tests.xlsx" remains open. This can produce errors if - for example - the workflows I am testing kills all Excel processes (as a KillAllProcesses workflow would do).

As the Excel Application Scope are only used to read workflows to test at the begining and write tests result at the end: Wouldn't it be better to close the file "Tests.xlsx" during the execution of tests to prevent this kind of errors ?

Here is how I think the workflow "RunAllTests" should look like (instead of wrapping the whole tests execution within one "Excel Application Scope")

Richard5Chan commented 3 years ago

Thanks for detailed screenshots and clarification. I agree it is not good practice to include unrelated activities of excel inside excel application scope. I would as also like to remove visible property of excel application scope to allow background execution.On 28/06/2021, 21:29 jestinga @.***> wrote:

Thanks for your answer. I may have not been very clear. The issue I encountered was that all the executions of tests are done within an Excel Application Scope (by default). So during the execution of tests the file "Tests.xlsx" remains open. This can produce errors if - for example - the workflows I am testing kills all Excel processes (as a KillAllProcesses workflow would do). As the Excel Application Scope are only used to read workflows to test at the begining and write tests result at the end: Wouldn't it be better to close the file "Tests.xlsx" during the execution of tests to prevent this kind of errors ? Here is how I think the workflow "RunAllTests" should look like (instead of wrapping the whole tests execution within one "Excel Application Scope") —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.