Closed jeffro256 closed 9 months ago
I need to update the Janus attack section, I think I edited locally and forgot to push the changes
Edit: done
Implementation note: a selfsend enote with a primary view tag must be randomly positioned in the list of selfsends.
Summary of changes as I understand them:
I really like the modifications you made to it. There was a lot of cleaning to do it seems ;)
I just pushed 2 commits which I think make the upfront description flow a little cleaner, and expand on npbits
details in later sections or in footnotes.
Ok, overall I am actually happy with the privacy improvements. This is a clean set of solutions to the targeted problems.
The costs are rather painful: 1 more address key, complexity for the view tag bit fiddling, 2x data on remote-scanner client, way slower to scan on the remote-scanner client (probably 100x).
I'm glad you're happy with the privacy improvements. At the risk of being unmodest, these changes are definitely opinionated, but I really like tradeoffs, and these Jamtis changes will probably be good enough for me to switch to a light wallet as my daily wallet (even though I do value privacy strongly). I agree, the costs are pretty painful, but hopefully the computational performance differences these changes bring will be more forgiving in real-world systems than they are on paper (real-world processors having multiple compute threads and mainly being bottle-necked by network I/O). Another personal opinion, but if there comes a time that a majority of light wallet users can not handle a small fraction of the on-chain enotes, that means that full wallets and nodes loads are likely struggling much worse, and there is scaling work to be done elsewhere.
Thanks for going through all the work to review!
Did some slight cleanup on your last commits.
what name and email address do you want to put in the author section?
jeffro256 <jeffro256@tutanota.com>
. Thanks for the credits!
PR implementing changes is here: https://github.com/UkoeHB/monero/pull/26