Improvements to sources tests

UkraineNow-Intel / autoSA-backend

Django backend for autoSA

0 stars 1 forks source link

Improvements to sources tests #13

Closed j-bennet closed 2 years ago

j-bennet commented 2 years ago

Follow-up PR to https://github.com/UkraineNow-Intel/autoSA-backend/pull/10.

handle updates and partial updates
including translations
introduce factories for tests
and switch to py.test.

D0nPiano commented 2 years ago

Looks good to me. The 'has_translations' variable in the update function of the source serializer could probably be simplified by just indenting the one line that is inbetween the if-calls - but that feels like I am really nit-picky. ...thank you for including the factories and testing the translations! :+1: