search

Ulauncher / ulauncher-timer

Timer Extension
50 stars 11 forks source link

Time formatting: why harcoded 12h-format ? #20

Open brunetton opened 1 year ago

brunetton commented 1 year ago

Hi. First of all thanks for this little piece of software; I'm using it with joy :)

One minor thing: I noticed that time format is 12h-format. Is there any reason for that ? I'm a French user, and here we're used to read "14:00" for 2PM.

Changing the date representation in Timer.description() from '%-I:%M %p' to '%-H:%M %p' solves the problem for me.

I think we Timer should refer to system for time format (en_US.UTF-8 will result is 12-hour format, and fr_FR.UTF-8 in 24h-format)

What do you think about it ?

Thanks

gornostal commented 1 year ago

I agree that it would be good to support 24h format. The reason for the AM/PM to be there was that someone contributed a PR with only that format support. I'm not actively supporting this extension. Feel free to submit a PR with 24h format support if you'd like.