search

Ulauncher / ulauncher.io

https://ulauncher.io
Other
4 stars 4 forks source link

Releases part is cached #6

Open friday opened 3 years ago

friday commented 3 years ago

This is how the releases show up for me in Chrome:

uncognito

Incognito window: incognito

friday commented 3 years ago

Oh, and if you don't want git issues here I can disable it again. I thought it was nice to keep them away from the app issues.

gornostal commented 3 years ago

Oh, and if you don't want git issues here I can disable it again. I thought it was nice to keep them away from the app issues.

That's fine. I agree!

Releases part is cached

That's intended because Github API has a request limits for non-authenticated requests. I'm caching it the releases for 2 minutes in browser's local storage. This shouldn't be an issue for regular users.

friday commented 3 years ago

I think it's happening before that. The cache never checked the GitHub releases url. I lasted for hours and only checked again when I force-reloaded. I guess I can check again next time I make a release.

friday commented 1 year ago

Update about this: I just pushed a new change to fix and improve the debian instructions further, and the new git action worked, so they're published :+1:

When I went to check the site, it was still showing the old info, and in the network requests it had the old cached version from November 13. Opening an incognito window worked though, as well as disabling cache in devtools and reloading.

Maybe it's more of an inconvenience than a real issue.

Screenshot from 2023-01-15 15-28-23

gornostal commented 1 year ago

I ran "cache invalidation" in cloudfront. This should fix the issue.