Uli12
commented
7 years ago Thank you! I keep an eye on class names as well as how to reduce repeated CSS lines.
Open franfranfranfran opened 7 years ago
Uli12
commented
7 years ago Thank you! I keep an eye on class names as well as how to reduce repeated CSS lines.
https://github.com/Uli12/TeaCozy/blob/master/resources/css/style.css#L113-L117 https://github.com/Uli12/TeaCozy/blob/master/resources/css/style.css#L143-L145 https://github.com/Uli12/TeaCozy/blob/master/resources/css/style.css#L28-L30 etc...
excellent job making use of flex display to help align items throughout the page! take a look at these places where you're setting that styling. is there a way to reduce the number of repeated lines in your css? what if we had a flex class that assigns the general stuff needed for flex and then you dive into the more specific details with the section class selector.
you do a great job using general classes like image, portland, and others to apply general styling to many sections at once. try taking this idea and using it for maybe more abstract styling. certain sections might not look exactly the same, but could share a good amount of styling.
as a side note - 'portland' might not be the most descriptive class name we could use here. consider using a class name that more closely represents what kind of info is held in that section. something like 'location' might make sense