search

Ullaakut / RTSPAllTheThings

Deprecated RTSP media server -- Use github.com/aler9/rtsp-simple-server instead.
Apache License 2.0
275 stars 72 forks source link

x264enc is using multiple slices #39

Closed david74chou closed 4 years ago

david74chou commented 6 years ago

Good job! RTSPATT is a great tool and its pattern mode is quite useful for auto testing.

However, I found current pipeline will set x264enc with tune=zerolatency which will make it uses 4 slices for one frame. I am not sure this is expected or not because multiple-slices is rarely used in the surveillance industry (Please correct me if I am wrong). Although ffplay and vlc could handle it correctly, OpenRTSP from live555 would generate invalid mp4.

Please consider to remove tune=zerolatency or set it to be single slice so that live555 could handle it correctly.

Thanks

Gegonz commented 6 years ago

Hi David,

The best approach would be encoder parameters according to the kind of input that you received or user defined. For now tune=zerolatency was useful to broadcast a RTSP stream (RTSPATT receive an RTSP stream and forward it) with as little latency as possible. But I agree it should not be by default, I will do a PR to remove it.