Ullaakut / RTSPAllTheThings

Deprecated RTSP media server -- Use github.com/aler9/rtsp-simple-server instead.
Apache License 2.0
278 stars 72 forks source link

Access authentication method #47

Closed Mera-balou closed 6 years ago

Mera-balou commented 6 years ago

Hi,

I 've just discovered your wonderful project and i have an enhancement to request. It seems that when you set up a username and a password, like this example command : docker run --rm -e RTSP_USERNAME=admin -e RTSP_PASSWORD=1234 -p 8554:8554 ullaakut/rtspatt , RTSPAll request by default a basic access authentication method.

In the RTSP RFC, both basic and digest access authentication methods are allowed. Is it possible to add an override options to choose which one we want (default:basic if not set), like [-e RTSP_AUTH=digest|basic]

Thanks

Ullaakut commented 6 years ago

Hi @Mera-balou !

I'm glad you find RTSTAPP useful :)

This sounds like quite a straight forward feature to implement, I'll get to it ASAP! 👍

Ullaakut commented 6 years ago

Alright so I've started an implementation and for this we'll need to build our own version of the GST RTSP server library, unfortunately, so this is going to take me some time, but I'm on it!

Ullaakut commented 6 years ago

Aaaand here you go: https://github.com/EtixLabs/RTSPAllTheThings/pull/48

I merged the PR, I will update the official docker image later this morning. I tested the feature on my machine and it seems to work fine 👌.

screen shot 2018-06-07 at 08 02 26 screen shot 2018-06-07 at 08 02 48

Let me know if that works for you as well, and if you have other feature requests, don't hesitate to tell me!

I know that there aren't a lot of options to serve RTSP and that the ones that exist are not very user friendly, so I really hope that with a bit more work on RTSPATT, we'll be able to help a significant amount of people. 😄

Mera-balou commented 6 years ago

Hi Ullaakut, I'm very impressed by your responsiveness. Well, let me try tonight or tomorrow and i will let you know about it.

Ullaakut commented 6 years ago

Sounds good, thanks 👍