search

Ullaakut / RTSPAllTheThings

Deprecated RTSP media server -- Use github.com/aler9/rtsp-simple-server instead.
Apache License 2.0
275 stars 72 forks source link

using builder pattern and ubuntu-18.04 upgrade #63

Closed enricomarchesin closed 5 years ago

enricomarchesin commented 5 years ago

upgraded ubuntu image to 18.04 to have a slimmer image (https://blog.ubuntu.com/2018/07/09/minimal-ubuntu-released) and switched to builder pattern for sources compilation (https://blog.alexellis.io/mutli-stage-docker-builds/)

enricomarchesin commented 5 years ago

Addressed the comment above.

Indeed the "ubuntu:18.04" is very optimised: I also tried with the, supposedly "super slim" minideb base image from Bitnami, but with the official one we can shave another 100 MB from the final image, down to close to 500 MB.

I'm sure you know the original image based on ubuntu:17.10 was 1000 MB in size: a 50% reduction modifying just a couple of lines! ☺️

Ullaakut commented 5 years ago

Addressed the comment above.

Indeed the "ubuntu:18.04" is very optimised: I also tried with the, supposedly "super slim" minideb base image from Bitnami, but with the official one we can shave another 100 MB from the final image, down to close to 500 MB.

I'm sure you know the original image based on ubuntu:17.10 was 1000 MB in size: a 50% reduction modifying just a couple of lines! ☺️

Looks good to me! Thanks for your contribution, once again! 🎉