Ullaakut / cameradar

Cameradar hacks its way into RTSP videosurveillance cameras
MIT License
3.99k stars 511 forks source link

Change Nmap to Masscan? #303

Open bugeja1989 opened 2 years ago

bugeja1989 commented 2 years ago

Can you change or customise the use between masscan and nmap

something like: https://github.com/zan8in/masscan

Ullaakut commented 2 years ago

Hi @bugeja1989 !

Why do you need Cameradar to use masscan over nmap?

Nmap should be able to discover RTSP hosts with no problem, just as well as masscan.

The repository you linked is a heavily inspired implementation of masscan bindings based on my nmap package, which is fine but I don't see why using it would improve Cameradar.

Ullaakut commented 1 year ago

Sure this would work 👍

Cameradar is not intended to be a tool used to discover exploitable IP cameras on the internet, it is intended to be a penetration testing tool, precisely aimed at small, specific targets.

There could be cases where masscan might be relevant, but they could easily tend towards the illegal, which is why I will not integrate masscan over nmap for Cameradar.

Unless you have another argument than scanning the whole internet, which is not the intended purpose of this tool, I do not think I'll change my mind 😄

Ullaakut commented 1 year ago

@phr34k0 I'm curious about your use case then, because if it is a valid one I'd be willing to offer the choice between using masscan and nmap during the discovery phase in Cameradar.

How many subnetworks do you usually need to scan in parallel? Do you work for a company with thousands of active sites with CCTV coverage? Do you then usually know the exact IPs of the cameras, or at least the IP ranges at which they are available, or do you have to guess and scan the whole network?

If it's not the case with your clients/company, note that surveillance cameras should always be on a separate network, isolated from the rest of the infrastructure, for multiple reasons:

That said, I could see a case where if you work for a large company and they ask you for a threat assessment of all of their networks without telling you where exactly IP cameras might or might not be available, that could take considerable time with Cameradar. It seems to me like quite an edge-case though 😬

Ullaakut commented 1 year ago

The thing is, it's going to get misused anyway 😄 I could see a valid case for having a private version of the repo with a masscan alternative, specifically accessible to people that I can be pretty sure will make good use for it though, if you are interested.

Disclaimer though, I do not have as much free time these days as I did when I wrote the tool so it could take some time.