Fix capitalization of internal package.

[dapperfu]

Case sensitive file systems have issues trying to reference the "internal package" of nmap/internal/slices.

github.com/ullaakut/nmap (download)
github.com/Ullaakut/nmap (download)
go/src/github.com/ullaakut/nmap/nmap.go:13:2: use of internal package github.com/Ullaakut/nmap/internal/slices not allowed

2 separate folders are created with each capitalization and the lower case one can't "use" the uppercase one as an internal package.

[dapperfu]

Well then, I guess we've come full circle. Go/GolangCI seems to have issues with case sensitivity. Technically scheme & host are case sensitive, the rest is not.

https://stackoverflow.com/a/26196170

[dapperfu]

So digging through the source code, it looks like you're mixing cases which Go seems to get angry about. I think if you fix all of these it should take care of that other open bug.

Capital U.

$ find `go env GOPATH` -name "*.go" | xargs grep Ull
/home/jed/go/src/github.com/ullaakut/nmap/nmap.go:  . "github.com/Ullaakut/nmap/internal/slices"
/home/jed/go/src/github.com/ullaakut/nmap/xml.go:   family "github.com/Ullaakut/nmap/pkg/osfamilies"
/home/jed/go/src/github.com/ullaakut/nmap/examples/spoof_and_decoys/main.go:    "github.com/Ullaakut/nmap"
/home/jed/go/src/github.com/ullaakut/nmap/examples/basic_scan_async/main.go:    "github.com/Ullaakut/nmap"
/home/jed/go/src/github.com/ullaakut/nmap/examples/count_hosts_by_os/main.go:   "github.com/Ullaakut/nmap"
/home/jed/go/src/github.com/ullaakut/nmap/examples/count_hosts_by_os/main.go:   osfamily "github.com/Ullaakut/nmap/pkg/osfamilies"
/home/jed/go/src/github.com/ullaakut/nmap/examples/basic_scan/main.go:  "github.com/Ullaakut/nmap"
/home/jed/go/src/github.com/ullaakut/nmap/examples/service_detection/main.go:   "github.com/Ullaakut/nmap"
/home/jed/go/src/github.com/ullaakut/nmap/xml_test.go:  family "github.com/Ullaakut/nmap/pkg/osfamilies"
/home/jed/go/src/github.com/Ullaakut/nmap/nmap.go:  . "github.com/Ullaakut/nmap/internal/slices"
/home/jed/go/src/github.com/Ullaakut/nmap/xml.go:   family "github.com/Ullaakut/nmap/pkg/osfamilies"
/home/jed/go/src/github.com/Ullaakut/nmap/examples/spoof_and_decoys/main.go:    "github.com/Ullaakut/nmap"
/home/jed/go/src/github.com/Ullaakut/nmap/examples/basic_scan_async/main.go:    "github.com/Ullaakut/nmap"
/home/jed/go/src/github.com/Ullaakut/nmap/examples/count_hosts_by_os/main.go:   "github.com/Ullaakut/nmap"
/home/jed/go/src/github.com/Ullaakut/nmap/examples/count_hosts_by_os/main.go:   osfamily "github.com/Ullaakut/nmap/pkg/osfamilies"
/home/jed/go/src/github.com/Ullaakut/nmap/examples/basic_scan/main.go:  "github.com/Ullaakut/nmap"
/home/jed/go/src/github.com/Ullaakut/nmap/examples/service_detection/main.go:   "github.com/Ullaakut/nmap"
/home/jed/go/src/github.com/Ullaakut/nmap/xml_test.go:  family "github.com/Ullaakut/nmap/pkg/osfamilies"

Lowercase u.

$ find `go env GOPATH` -name "*.go" | xargs grep ullaakut
/home/jed/go/src/github.com/ullaakut/disgo/step.go: "github.com/ullaakut/disgo/style"
/home/jed/go/src/github.com/ullaakut/disgo/examples/global/main.go: "github.com/ullaakut/disgo"
/home/jed/go/src/github.com/ullaakut/disgo/examples/global/main.go: "github.com/ullaakut/disgo/style"
/home/jed/go/src/github.com/ullaakut/disgo/examples/advanced/main.go:   "github.com/ullaakut/disgo"
/home/jed/go/src/github.com/ullaakut/disgo/examples/advanced/main.go:   "github.com/ullaakut/disgo/style"
/home/jed/go/src/github.com/Ullaakut/cameradar/scan.go: "github.com/ullaakut/nmap"
/home/jed/go/src/github.com/Ullaakut/cameradar/cameradar.go:// https://github.com/ullaakut/cameradar/tree/master/cameradar
/home/jed/go/src/github.com/Ullaakut/cameradar/loaders_test.go: "github.com/ullaakut/disgo"
/home/jed/go/src/github.com/Ullaakut/cameradar/curl_test.go:    curl "github.com/ullaakut/go-curl"
/home/jed/go/src/github.com/Ullaakut/cameradar/scanner_test.go: curl "github.com/ullaakut/go-curl"
/home/jed/go/src/github.com/Ullaakut/cameradar/attack.go:   curl "github.com/ullaakut/go-curl"
/home/jed/go/src/github.com/Ullaakut/cameradar/summary.go:  "github.com/ullaakut/disgo/style"
/home/jed/go/src/github.com/Ullaakut/cameradar/summary.go:  curl "github.com/ullaakut/go-curl"
/home/jed/go/src/github.com/Ullaakut/cameradar/cmd/cameradar/cameradar.go:  "github.com/ullaakut/cameradar"
/home/jed/go/src/github.com/Ullaakut/cameradar/cmd/cameradar/cameradar.go:  "github.com/ullaakut/disgo"
/home/jed/go/src/github.com/Ullaakut/cameradar/cmd/cameradar/cameradar.go:  "github.com/ullaakut/disgo/style"
/home/jed/go/src/github.com/Ullaakut/cameradar/cmd/cameradar/cameradar.go:  pflag.StringP("custom-routes", "r", "${GOPATH}/src/github.com/ullaakut/cameradar/dictionaries/routes", "The path on which to load a custom routes dictionary")
/home/jed/go/src/github.com/Ullaakut/cameradar/cmd/cameradar/cameradar.go:  pflag.StringP("custom-credentials", "c", "${GOPATH}/src/github.com/ullaakut/cameradar/dictionaries/credentials.json", "The path on which to load a custom credentials JSON dictionary")
/home/jed/go/src/github.com/Ullaakut/cameradar/tools/dictionary_updater/main.go:    "github.com/ullaakut/disgo/style"
/home/jed/go/src/github.com/Ullaakut/cameradar/tools/dictionary_updater/main.go:    "github.com/ullaakut/disgo"
/home/jed/go/src/github.com/Ullaakut/cameradar/attack_test.go:  "github.com/ullaakut/disgo"
/home/jed/go/src/github.com/Ullaakut/cameradar/attack_test.go:  curl "github.com/ullaakut/go-curl"
/home/jed/go/src/github.com/Ullaakut/cameradar/curl.go: curl "github.com/ullaakut/go-curl"
/home/jed/go/src/github.com/Ullaakut/cameradar/helpers_test.go:     Username: "ullaakut",
/home/jed/go/src/github.com/Ullaakut/cameradar/helpers_test.go:         expectedRTSPURL: "rtsp://ullaakut:ba69897483886f0d2b0afb6345b76c0c@1.2.3.4:1337/cameradar.sdp",
/home/jed/go/src/github.com/Ullaakut/cameradar/summary_test.go: "github.com/ullaakut/disgo"
/home/jed/go/src/github.com/Ullaakut/cameradar/scan_test.go:    "github.com/ullaakut/disgo"
/home/jed/go/src/github.com/Ullaakut/cameradar/scan_test.go:    "github.com/ullaakut/nmap"
/home/jed/go/src/github.com/Ullaakut/cameradar/scanner.go:  "github.com/ullaakut/disgo"
/home/jed/go/src/github.com/Ullaakut/cameradar/scanner.go:  "github.com/ullaakut/disgo/style"
/home/jed/go/src/github.com/Ullaakut/cameradar/scanner.go:  curl "github.com/ullaakut/go-curl"
/home/jed/go/src/github.com/Ullaakut/cameradar/scanner.go:  defaultCredentialDictionaryPath = "${GOPATH}/src/github.com/ullaakut/cameradar/dictionaries/credentials.json"
/home/jed/go/src/github.com/Ullaakut/cameradar/scanner.go:  defaultRouteDictionaryPath      = "${GOPATH}/src/github.com/ullaakut/cameradar/dictionaries/routes"

[Ullaakut]

Hi @jed-frey!

Thanks for the PR :)

Yeah this is a known issue, unfortunately I don't have much time at the moment to take care of it at the moment :( I'll try to fix it on all of my repos at once this weekend, thanks for the reminder!