Closed Neverhorst closed 10 months ago
Had a hard time so far to reproduce the error even without the fix in this PR (except for changing the deprecated np.float
part).
At what point should one delete the fit? Deleting from the dumped StatusVariable file in AppData? Or should one delete the subclass of FitModelBase
in the qudi-core code?? ... Kind of lost, to be honest. Maybe I am missing something with regards to the "custom fit models", mentioned in Issue #59 on how to include those?
Had a hard time so far to reproduce the error even without the fix in this PR (except for changing the deprecated
np.float
part).
Yeah it is a bit tricky. For example you can perform the following steps to reproduce the issue:
ExponentialDecay
qudi.util.fit_models.model.FitModelBase
subclass in qudi.util.fit_models
(e.g. qudi.util.fit_models.exp_decay.ExponentialDecay
in qudi-core
) and comment out this class
Description
Fixes a bug where all fit configurations for a fit model/container fail to load upon activation of a module because the fit model saved in AppData is no longer available. Throws a warning now instead and ignores the respective fit configuration.
Motivation and Context
Resolves #59 Also fixes a deprecated usage of the
numpy.float()
constructor.How Has This Been Tested?
Types of changes
Checklist:
/docs/changelog.md
.