Ulm-IQO / qudi

(Legacy project) A modular laboratory experiment management suite, predecessor to qudi-core.
GNU General Public License v3.0
165 stars 140 forks source link

Fixed two typing errors, where float values are passed to PyQt5 metho… #704

Closed sidneycadot closed 2 years ago

sidneycadot commented 2 years ago

Fixed two typing errors, where float values are passed to PyQt5 methods that expect integers.

This issue leads to exceptions being thrown in (at least) Python 3.10.6 with PyQt5.

The solution is to round the float values prior to passing them as parameters.

it is conceivable that more issues like this are present in the code-base, but I haven't encountered them. Perhaps a thorough use of mypy could help to spot them.