When using hotkey inside comment program stopping respond

UltCombo / atom-sublime-block-comment

An Atom Editor plugin to toggle block comments, inspired by Sublime Text.

MIT License

10 stars 2 forks source link

When using hotkey inside comment program stopping respond #5

Open irvnriir opened 7 years ago

irvnriir commented 7 years ago

Any additional info i can provide ?

UltCombo commented 7 years ago

Yes, please provide as much info as you can.

Are you using the latest Atom version?
Does it freeze only temporarily or is it permanent and you have to restart Atom?
Does the issue trigger every time or just for specific cases? If the latter, can you provide a sample text that triggers the issue? Where's the cursor/selection(s) in that text when you press the hotkey and it freezes?
Also, what Atom syntax were you using at the time (JavaScript, Python, Java, a custom syntax highlighter)?

irvnriir commented 7 years ago

yes permanently every time sqf (right thing, i tryed and in C# (same comments syntax) for example its working fine)

UltCombo commented 7 years ago

Thanks!

I'd bet the sqf language uses different scope descriptors for comments (from the command palette, select "Editor: Log Cursor Scope") than the ones supported here: [1] [2]

I'm short on time to investigate it now though.

irvnriir commented 7 years ago

https://github.com/acemod/language-arma-atom/blob/master/grammars/sqf.json#L8-L21 Not sure how to write it in

irvnriir commented 7 years ago

Can some change in the SQF package help fixing or fix the issue ?

muaadhsherif commented 6 years ago

I think we don't have a need to use this package as atom does this without packages. Just type: ctrl-/ : to make the hole line as a comment. ctrl-shift-/: to comment the selected text and if there is no-selected text it gives you an empty comment.

irvnriir commented 6 years ago

@muaadhsherif obviously it doing this differently

muaadhsherif commented 6 years ago

I'm very sorry for the previous comment. I'll delete it. I don't know, yesterday ctrl + shift + / was working but now it doesn't. I don't know the reason. I think Because I uninstalled another package and then ctrl+shift+/ was still working, so I thought It works without the package. Maybe first I had to reopen Atom. I'm sorry.