Remove forking on deactivation

UltCombo / ult-terminal

UltCombo's Atom terminal.

MIT License

2 stars 1 forks source link

Remove forking on deactivation #12

Closed UltCombo closed 9 years ago

UltCombo commented 9 years ago

It looks like forking is no longer necessary.

All of these actions properly kill the entire process tree (tested on OS X): reloading Atom, closing Atom window, Cmd+Q, deactivating package.

I'll test a bit more on Windows before merging. This task is much more straightforward and less error-prone in Windows, so hopefully there won't be any issues.

UltCombo commented 9 years ago

Tested on Windows: reload Atom, close last Atom window, kill Atom process (via task manager), disable package.

Looks like this is good for merging.